Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust Release 1.63.0 add a new lint borrow_deref_ref causing Cargo Clippy error #38

Closed
francis-du opened this issue Aug 19, 2022 · 4 comments

Comments

@francis-du
Copy link
Contributor

https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

image

@andygrove
Copy link
Member

Should be fixed when pyo3 0.17 is released. The issue is already fixed in their repo. See PyO3/pyo3#2555

@andygrove
Copy link
Member

The other option is to use String instead of &str for arguments in python methods.

@francis-du
Copy link
Contributor Author

Should we fix it by updating pyo3 or by modifying the parameter type?

@andygrove
Copy link
Member

pyo3 0.17 is now available but we have to update in arrow-rs and then arrow-datafusion and wait for a new release before we can update here.

IMO, changing the signature for now would be quicker and we can change it back later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants