From bed7322fa14d7f7cfda23ff2bccc28fb416eac9d Mon Sep 17 00:00:00 2001 From: Steve Lau Date: Wed, 21 Feb 2024 18:02:19 +0800 Subject: [PATCH] refactor: complete 2 TODOs in self review --- datafusion/functions/src/math/acos.rs | 2 +- datafusion/proto/Cargo.toml | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/datafusion/functions/src/math/acos.rs b/datafusion/functions/src/math/acos.rs index ef5fa58530650..8fe1905ae3c0f 100644 --- a/datafusion/functions/src/math/acos.rs +++ b/datafusion/functions/src/math/acos.rs @@ -82,7 +82,7 @@ impl ScalarUDFImpl for AcosFunc { DataType::Float32 => { Arc::new(make_function_scalar_inputs_return_type!( &args[0], - "x", + self.name(), Float32Array, Float32Array, { f32::acos } diff --git a/datafusion/proto/Cargo.toml b/datafusion/proto/Cargo.toml index cba4c526bb681..59a9129c6d7a0 100644 --- a/datafusion/proto/Cargo.toml +++ b/datafusion/proto/Cargo.toml @@ -47,7 +47,6 @@ chrono = { workspace = true } datafusion = { path = "../core", version = "36.0.0" } datafusion-common = { workspace = true } datafusion-expr = { workspace = true } -datafusion-functions = { workspace = true } object_store = { workspace = true } pbjson = { version = "0.6.0", optional = true } prost = "0.12.0"