Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ordering serialization for AggregateUdf in datafusion-proto #11804

Closed
alamb opened this issue Aug 4, 2024 · 0 comments · Fixed by #11926
Closed

Implement ordering serialization for AggregateUdf in datafusion-proto #11804

alamb opened this issue Aug 4, 2024 · 0 comments · Fixed by #11926
Labels
enhancement New feature or request regression Something that used to work no longer does

Comments

@alamb
Copy link
Contributor

alamb commented Aug 4, 2024

Is your feature request related to a problem or challenge?

As @jayzhan211 points out on #11013 (comment) the ordering_req field is not supported when serializating/deserializing aggregate udfs

Describe the solution you'd like

Add ordering_req to the serialization / deserializton of aggregateudf and add a test

Describe alternatives you've considered

Here is the code where the ordeirng is ignored when serializing

let _ordering_req: Vec<PhysicalSortExpr> = agg_node.ordering_req.iter()
.map(|e| parse_physical_sort_expr(e, registry, &physical_schema, extension_codec)).collect::<Result<Vec<_>>>()?;

Additional context

I think technically this may be a regression as builtin functions had proper ordering serialization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request regression Something that used to work no longer does
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant