Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not support similar to expr run in physical expr? #12155

Closed
zhuliquan opened this issue Aug 25, 2024 · 1 comment · Fixed by #12350
Closed

not support similar to expr run in physical expr? #12155

zhuliquan opened this issue Aug 25, 2024 · 1 comment · Fixed by #12350
Assignees
Labels
bug Something isn't working

Comments

@zhuliquan
Copy link
Contributor

Describe the bug

There is SimilarTo expr in logical expr

SimilarTo(Like),

However, there is not arm for SimilarTo expr in func create_physical_expr (in datafusion/physical-expr/src/planner.rs:L106)
If I write sql include SimilarTo expr will got a panic which throw from below code
other => {
not_impl_err!("Physical plan does not support logical expression {other:?}")
}

For example:

> select * from t1 where c1 similar to 'x*';
This feature is not implemented: Physical plan does not support logical expression SimilarTo(Like { negated: false, expr: Column(Column { relation: Some(Bare { table: "t1" }), name: "c1" }), pattern: Literal(Utf8("x*")), escape_char: None, case_insensitive: false })

To Reproduce

No response

Expected behavior

No response

Additional context

Whether to consider removing the SimilarTo expression from the logical expression or add arm for it to convert to a special physical expression in func create_physical_expr

@zhuliquan zhuliquan added the bug Something isn't working label Aug 25, 2024
@theirix
Copy link
Contributor

theirix commented Aug 26, 2024

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants