Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sum(distinct) support #2404

Closed
WinkerDu opened this issue May 2, 2022 · 0 comments · Fixed by #2405
Closed

sum(distinct) support #2404

WinkerDu opened this issue May 2, 2022 · 0 comments · Fixed by #2405
Labels
enhancement New feature or request

Comments

@WinkerDu
Copy link
Contributor

WinkerDu commented May 2, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

For now, DataFusion hasn't support sum(distinct) yet. Though optimizer SingleDistinctToGroupBy (#1315) supports single distinct usage, there are more SQL scenes have not been covered.
For example, run the following unit test,

#[tokio::test]
async fn query_sum_distinct() -> Result<()> {
    let schema = Arc::new(Schema::new(vec![
        Field::new("c1", DataType::Int64, true),
        Field::new("c2", DataType::Int64, true),
    ]));

    let data = RecordBatch::try_new(
        schema.clone(),
        vec![
            Arc::new(Int64Array::from(vec![
                Some(0),
                Some(1),
                None,
                Some(3),
                Some(3),
            ])),
            Arc::new(Int64Array::from(vec![
                None,
                Some(1),
                Some(1),
                Some(2),
                Some(2),
            ])),
        ],
    )?;

    let table = MemTable::try_new(schema, vec![vec![data]])?;
    let ctx = SessionContext::new();
    ctx.register_table("test", Arc::new(table))?;

    let sql = "SELECT AVG(c1), SUM(DISTINCT c2) FROM test";
    let actual = execute_to_batches(&ctx, sql).await;
    Ok(())
}

then error raises like

NotImplemented(\"SUM(DISTINCT) aggregations are not available\") at Creating physical plan for 'SELECT AVG(c1), SUM(DISTINCT c2) FROM test': Projection: #AVG(test.c1), #SUM(DISTINCT test.c2)\n  Aggregate: groupBy=[[]], aggr=[[AVG(#test.c1), SUM(DISTINCT #test.c2)]]\n    TableScan: test projection=Some([0, 1])

Describe the solution you'd like
Introduces expressions::DistinctSum into DF

  • Maintains a HashSet to record unique numeric list, update HashSet when new item input.
  • Aggregate state stores in ScalarValue::List, which Built from HashSet.
  • During Final aggregate, evaluate DistinctSum by computing sum from numeric stored in HashSet

Describe alternatives you've considered
No.

Additional context
No.

@WinkerDu WinkerDu added the enhancement New feature or request label May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant