Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the header not changed when do optimization #3568

Open
liukun4515 opened this issue Sep 21, 2022 · 3 comments
Open

make the header not changed when do optimization #3568

liukun4515 opened this issue Sep 21, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@liukun4515
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to the what)

In thist pr #3444

we provide a discussion about the header of the result.

The result always changes if do some optimization.
I have be stucked by this issue for doing this pr #3396

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@liukun4515 liukun4515 added the enhancement New feature or request label Sep 21, 2022
@Dandandan
Copy link
Contributor

Also see #279 #280 for extra context and a proposed implementation

@liukun4515
Copy link
Contributor Author

Also see #279 #280 for extra context and a proposed implementation

when are we going to merge or review them? @Dandandan

@Dandandan
Copy link
Contributor

Also see #279 #280 for extra context and a proposed implementation

when are we going to merge or review them? @Dandandan

I think the PR is outdated. I think someone (you maybe?) can look at the changes and update the tests so it can be reviewed again 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants