Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coerce API so it doesn't need DF Schema #3793

Closed
alamb opened this issue Oct 11, 2022 · 0 comments · Fixed by #10331
Closed

Improve coerce API so it doesn't need DF Schema #3793

alamb opened this issue Oct 11, 2022 · 0 comments · Fixed by #10331
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Oct 11, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I am trying to use the DataFusion Expr struct along with the expression simplification feature -- see #3708 and #3741 for examples / description of what this means

Type coercion is involved because of this chain:

#3758 adds an API to call coerce so that simplify can work in more cases.

However, the API requires a DFSchema, some wrapper type over Schema that is non trivial to compute. The Simplify API already takes a trait SimplifyInfo to provide just the information required. It would be nice if the coercion function did too, and was called directly as part of the coercion API.

Describe the solution you'd like
I would like the signature of coerce addd in #3758 to take a SimplifyInfo rather than DFSchema

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
See https://github.com/influxdata/influxdb_iox/pull/5792 for examples of when IOx uses the simplification (and thus needs to call coerce)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant