Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all sqllogictest, even if there are test failures in between #4734

Closed
Tracked by #4460
xudong963 opened this issue Dec 26, 2022 · 3 comments · Fixed by #6393
Closed
Tracked by #4460

Run all sqllogictest, even if there are test failures in between #4734

xudong963 opened this issue Dec 26, 2022 · 3 comments · Fixed by #6393
Assignees
Labels
enhancement New feature or request sqllogictest SQL Logic Tests (.slt)

Comments

@xudong963
Copy link
Member

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Run all sqllogictest, even if there are test failures in between.

When tests are run on CI, it will be more efficient if logictests can be run all the way through and report all failed cases.

Describe the solution you'd like
Does sqllogictest-rs have support for this, or does it need to be implemented on the user side? cc @xxchan

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@xudong963 xudong963 added enhancement New feature or request sqllogictest SQL Logic Tests (.slt) labels Dec 26, 2022
@xudong963 xudong963 mentioned this issue Dec 26, 2022
28 tasks
@xxchan
Copy link
Contributor

xxchan commented Dec 26, 2022

Does sqllogictest-rs have support for this, or does it need to be implemented on the user side?

Currently sqllogictest runner only has very thin wrappers (run_multi, run_file) over run (record). You need to implement custome testing logic. BTW, you may refer to sqllogictest-bin.

@xxchan
Copy link
Contributor

xxchan commented Dec 26, 2022

BTW, if you want to keep running later records in a file, that might be problematic, e.g., imagine a CREATE TABLE failed. But anyway you can implement any suitable policy using the basic building blocks.

@alamb
Copy link
Contributor

alamb commented May 24, 2023

After reviewing this request I think #6393 will fix it (runs all test files and reports errors)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants