Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move type_coercion to the front of logical optimizer #5235

Closed
HaoYang670 opened this issue Feb 10, 2023 · 2 comments
Closed

Move type_coercion to the front of logical optimizer #5235

HaoYang670 opened this issue Feb 10, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@HaoYang670
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
This is just a placeholder, which we can't do this until completing #4615.

Type_coercion and type checking is something we must do on a query, not an optional optimizing pass. So it is more reasonable to move it to the front of the logical optimization.

Also, we should try to remove the type_coercion in physical plan, so that our queries can be totally statically typed.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@HaoYang670 HaoYang670 added the enhancement New feature or request label Feb 10, 2023
@HaoYang670 HaoYang670 changed the title Move type_coercion out of the logical optimizer Move type_coercion to the front of logical optimizer Feb 10, 2023
@wolffcm
Copy link
Contributor

wolffcm commented Mar 24, 2023

I commented on #4615 with a DF use case (for IOx) that I think also relevant here: #4615 (comment)

@HaoYang670
Copy link
Contributor Author

Close this as it has been fixed by #5831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants