You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Which do not make it easy to understand the context in which the error was encountered. Typically the approach I follow is to use an interactive debugger, such as GDB, to catch the error. However, this requires having a local reproducer, which isn't always possible.
Describe the solution you'd like
Backtraces are a commonly used mechanism to automatically provide context on where an error was encountered. Whilst they have issues, especially in async contexts, they are better than the current situation where diagnosing such issues is non-trivial.
Adding a backtrace to the error variants that have corresponding From conversions, i.e. ArrowError, ParquetError, AvroError, ObjectStore, IoError, SchemaError, etc... would automatically capture the context in which this conversion is performed.
APIs can then use DataFusionError::find_root to get the leaf variant, and from that extract the backtrace if any.
This is predicated on the fact that DataFusionError is rarely used to implement control flow, and so the cost of obtaining a backtrace is only paid on exceptional paths.
Describe alternatives you've considered
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered:
This is great and really needed. I was struggling several times to navigate to the rootcause from DF to arrow-rs. I believe doing the same from Ballista is even more complicated.
Btw we can try add a function name to the caller like https://stackoverflow.com/a/40234666/11285252
whats happening now is rethrow the DataFusionError multiple times so the error origin get lost completely
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
It is fairly common to get errors from DataFusion such as in apache/datafusion-ballista#665
Which do not make it easy to understand the context in which the error was encountered. Typically the approach I follow is to use an interactive debugger, such as GDB, to catch the error. However, this requires having a local reproducer, which isn't always possible.
Describe the solution you'd like
Backtraces are a commonly used mechanism to automatically provide context on where an error was encountered. Whilst they have issues, especially in async contexts, they are better than the current situation where diagnosing such issues is non-trivial.
Adding a backtrace to the error variants that have corresponding
From
conversions, i.e.ArrowError
,ParquetError
,AvroError
,ObjectStore
,IoError
,SchemaError
, etc... would automatically capture the context in which this conversion is performed.APIs can then use
DataFusionError::find_root
to get the leaf variant, and from that extract the backtrace if any.This is predicated on the fact that
DataFusionError
is rarely used to implement control flow, and so the cost of obtaining a backtrace is only paid on exceptional paths.Describe alternatives you've considered
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: