You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
End applications often translate internal errors into something different (aka hide details from the user as they can't do anything about it) rather than a Plan or Execution error (which signals an issue in the query)
Describe the solution you'd like
Audit all the uses of DataFusionError::Internal errors and change any to DataFusion::Plan or DataFusion::Execution as appropriate
Update the doc strings on DataFusionError to make it clear DataFusionError::Internal should be used only when there is a bug in DataFusion (rather than an error in the query)
Logical optimizer rules should be able to fail in a way that advises the user on how to correct their query, rather than having the optimizer assume that any error is internal. This is relevant to https://github.com/influxdata/influxdb_iox/issues/7330
Is your feature request related to a problem or challenge?
There are a variety of places where internal errors are raised in DataFusion:
https://github.com/search?q=repo%3Aapache%2Farrow-datafusion+DataFusionError%3A%3AInternal&type=code
End applications often translate internal errors into something different (aka hide details from the user as they can't do anything about it) rather than a Plan or Execution error (which signals an issue in the query)
Describe the solution you'd like
DataFusionError::Internal
errors and change any toDataFusion::Plan
orDataFusion::Execution
as appropriateDataFusionError
to make it clearDataFusionError::Internal
should be used only when there is a bug in DataFusion (rather than an error in the query)Describe alternatives you've considered
No response
Additional context
https://github.com/influxdata/influxdb_iox/issues/7606
The text was updated successfully, but these errors were encountered: