Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring the array ecosystem #7279

Closed
4 tasks
izveigor opened this issue Aug 14, 2023 · 3 comments
Closed
4 tasks

Refactoring the array ecosystem #7279

izveigor opened this issue Aug 14, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@izveigor
Copy link
Contributor

Is your feature request related to a problem or challenge?

File codebase array_expressions increased from a few lines to a thousand in a few weeks. Arrow Datafusion now supports more than 20 array functions: we can create array by make_array function, find any element or replace it. At this stage, it would be wise to clean up the code.

Goals of refactoring 🎯:

  • data types
  • tests
  • functionality of array functions
  • add beautiful comments

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@alamb
Copy link
Contributor

alamb commented Aug 14, 2023

cc @tustvold who was just showing me that the amount of code generated for some of the array functions generated non trivial binary code size

@jayzhan211
Copy link
Contributor

This can be closed together with #7988

@alamb
Copy link
Contributor

alamb commented Dec 9, 2023

Thank you very much @jayzhan211

@alamb alamb closed this as completed Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants