Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run cargo audit #9116

Closed
Jefffrey opened this issue Feb 2, 2024 · 6 comments · Fixed by #9182
Closed

ci: run cargo audit #9116

Jefffrey opened this issue Feb 2, 2024 · 6 comments · Fixed by #9182
Labels
development-process Related to development process of DataFusion enhancement New feature or request good first issue Good for newcomers

Comments

@Jefffrey
Copy link
Contributor

Jefffrey commented Feb 2, 2024

Is your feature request related to a problem or challenge?

Run cargo audit as part of CI

Describe the solution you'd like

See arrow-rs: apache/arrow-rs#5160

Describe alternatives you've considered

Don't do this

Additional context

Looks like this was attempted before: #599

Though this was attempting to run it on schedule. In the arrow-rs PR above it only runs on PR/commits to master

DataFusion probably moves fast enough that commits to main are enough for triggering audit check, but can explore making it scheduled again

Note that will not be able to use the audit GitHub action and will instead need to run it manually, as was not able to use the GitHub action due to some policy blocking external action use (or something like that)

@Jefffrey Jefffrey added enhancement New feature or request development-process Related to development process of DataFusion good first issue Good for newcomers labels Feb 2, 2024
@Jefffrey
Copy link
Contributor Author

Jefffrey commented Feb 2, 2024

Marking as good first issue as there is the arrow-rs PR to base off from, and is self contained to only CI for this repo

@ongchi
Copy link
Contributor

ongchi commented Feb 6, 2024

I noticed there is a fork of original audit-check action. I think this could be trusted since it is run by the Rust Secure Code WG.
It would save much time and bandwidth on compilation and installation of cargo-audit in CI.

@Jefffrey
Copy link
Contributor Author

Jefffrey commented Feb 6, 2024

I noticed there is a fork of original audit-check action. I think this could be trusted since it is run by the Rust Secure Code WG. It would save much time and bandwidth on compilation and installation of cargo-audit in CI.

I think I tried that action before but was unable to get it to run in CI, see:

apache/arrow-rs#5160 (comment)

So I opted for just including the shell steps manually, but if there's another way to get around that above error and use that audit-check action then I'm all for it 👍

@ongchi
Copy link
Contributor

ongchi commented Feb 7, 2024

Hello @Jefffrey,
I tried that action and it seems to works well.
Here is the log.

@Jefffrey
Copy link
Contributor Author

Jefffrey commented Feb 8, 2024

Ah that's great then 👍

Feel free to submit a PR with this added 👀

@alamb
Copy link
Contributor

alamb commented Feb 8, 2024

DataFusion probably moves fast enough that commits to main are enough for triggering audit check, but can explore making it scheduled again

I agree triggering on commits to main would be good enough. Thank you @ongchi and @Jefffrey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants