Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ScalarValue list variant using Array trait object #996

Closed
houqp opened this issue Sep 13, 2021 · 1 comment · Fixed by #7629
Closed

Optimize ScalarValue list variant using Array trait object #996

houqp opened this issue Sep 13, 2021 · 1 comment · Fixed by #7629
Labels
enhancement New feature or request

Comments

@houqp
Copy link
Member

houqp commented Sep 13, 2021

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

This comes out from the arrow2 PR started by @jorgecarleitao. Here is a discussion on why it would be more efficient to model ScalarValue as dyn Array: #68 (comment)

Describe the solution you'd like

Change ScalarValue's List variant to:

List(Option<Arc<dyn Array>>, DataType),

Describe alternatives you've considered

Current way of warping every list value with a ScalarValue enum has a lot of overhead on read/write.

Additional context

We should probably wait for the arrow2 PR merge before starting to work on this.

#68 (comment) has more discussion on how we can handle this in ballista's protobuf ser/de.

@alamb
Copy link
Contributor

alamb commented Aug 21, 2023

Closing in favor of #7352 whihc offers a more modern proposal for this same idea. Otherwise known as "its happening!"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants