-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature](literal)Support TimeV2Literal #47319
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 32300 ms
|
TPC-DS: Total hot run time: 195154 ms
|
ClickBench: Total hot run time: 30.98 s
|
run p0 |
1 similar comment
run p0 |
run buildall |
run buildall |
TPC-H: Total hot run time: 32669 ms
|
TPC-DS: Total hot run time: 184397 ms
|
ClickBench: Total hot run time: 30.49 s
|
run buildall |
TeamCity be ut coverage result: |
run buildall |
TPC-H: Total hot run time: 32315 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 192714 ms
|
ClickBench: Total hot run time: 30.85 s
|
run buildall |
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 32492 ms
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 31362 ms
|
TPC-DS: Total hot run time: 190227 ms
|
ClickBench: Total hot run time: 31.08 s
|
run beut |
TeamCity be ut coverage result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by anyone and no changes requested. |
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/TimeLiteral.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/Literal.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/Literal.java
Outdated
Show resolved
Hide resolved
run buildall |
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 31685 ms
|
TPC-DS: Total hot run time: 190480 ms
|
TeamCity be ut coverage result: |
run performance |
TPC-H: Total hot run time: 31915 ms
|
TPC-DS: Total hot run time: 183603 ms
|
ClickBench: Total hot run time: 30.02 s
|
be/src/vec/functions/function_cast.h
Outdated
@@ -169,6 +169,12 @@ struct TimeCast { | |||
num = int_value; | |||
return true; | |||
}; | |||
bool neg {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better use sign
, sign
maybe is 1 or -1
run buildall |
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 31838 ms
|
TPC-DS: Total hot run time: 182897 ms
|
ClickBench: Total hot run time: 30.29 s
|
TeamCity be ut coverage result: |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)