Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QTL problem during upgrade to 0.10.x #4603

Closed
drcrallen opened this issue Jul 26, 2017 · 6 comments
Closed

QTL problem during upgrade to 0.10.x #4603

drcrallen opened this issue Jul 26, 2017 · 6 comments
Labels
Milestone

Comments

@drcrallen
Copy link
Contributor

During the course of upgrading, there is a time where historicals and the coordinator will be on different versions. When the historicals are updated to the latest version, they like to spew the following error:

got notice to load lookup [LookupExtractorFactoryContainer{version='null', lookupExtractorFactory=io.druid.query.lookup.NamespaceLookupExtractorFactory@*}] that can't replace existing [LookupExtractorFactoryContainer{version='null', lookupExtractorFactory=io.druid.query.lookup.NamespaceLookupExtractorFactory@*
@drcrallen drcrallen added the Bug label Jul 26, 2017
@drcrallen drcrallen added this to the 0.10.1 milestone Jul 26, 2017
@drcrallen
Copy link
Contributor Author

This might just be noise during the switchover, but is very annoying

@gianm
Copy link
Contributor

gianm commented Jul 26, 2017

@himanshug do you know if this is expected or not?

@himanshug
Copy link
Contributor

@drcrallen @gianm it is expected. The reason is that when historical is on 0.10.1 while coordinator is on smaller version, coordinator would try to propagate lookups to historical even if they are already loaded on the historical... historical prints a warning on receiving request to load a lookup whose same or higher version is already loaded.
warning message is intended to find out any bugs in coordinator code, 0.10.1 coordinator is suppose to first check with historical what it has and then ask it to do stuff so these warnings shouldn't get printed once coordinator is upgraded too.

@drcrallen
Copy link
Contributor Author

The concern is that it reports as an error but isn't really an error, which makes it harder to catch real errors. I propose simply calling it out in the release notes.

@drcrallen
Copy link
Contributor Author

Resolving by adding info to release notes

@himanshug
Copy link
Contributor

@drcrallen I believe the message to be printed from https://github.com/druid-io/druid/blob/0.10.1/processing/src/main/java/io/druid/query/lookup/LookupReferencesManager.java#L366 which is a "warn" not "error" . Did you see "error" printed ? that would be unexpected.
in any case, i think its great to put it in release notes to avoid surprises. @drcrallen @jon-wei thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants