-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getters for AlertEvent #5505
Comments
|
I could see a good argument for making AlertEvent, ServiceMetricEvent, and RequestLogEvent public APIs. It's useful to poke at them in emitter extensions. |
This issue has been marked as stale due to 280 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the [email protected] list. Thank you for your contributions. |
This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. |
Specific getter methods (getService() and getDataMap()) for AlertEvent were removed as part of #5461
https://github.com/druid-io/druid/blob/master/java-util/src/main/java/io/druid/java/util/emitter/service/AlertEvent.java
Our internal alerting extension makes use of these methods and consequently they have started failing. If the only reason for the removal was their non-usage, can we get them added back please.
Unfortunately, I missed the PR before it was merged, else I could have raised a concern there. Thoughts @leventov ?
The text was updated successfully, but these errors were encountered: