Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getters for AlertEvent #5505

Closed
a2l007 opened this issue Mar 19, 2018 · 4 comments
Closed

Add getters for AlertEvent #5505

a2l007 opened this issue Mar 19, 2018 · 4 comments

Comments

@a2l007
Copy link
Contributor

a2l007 commented Mar 19, 2018

Specific getter methods (getService() and getDataMap()) for AlertEvent were removed as part of #5461
https://github.com/druid-io/druid/blob/master/java-util/src/main/java/io/druid/java/util/emitter/service/AlertEvent.java
Our internal alerting extension makes use of these methods and consequently they have started failing. If the only reason for the removal was their non-usage, can we get them added back please.
Unfortunately, I missed the PR before it was merged, else I could have raised a concern there. Thoughts @leventov ?

@leventov
Copy link
Member

AlertEvent is not marked as @PublicApi. It could be, but other committers should agree on that.

@gianm
Copy link
Contributor

gianm commented Mar 21, 2018

I could see a good argument for making AlertEvent, ServiceMetricEvent, and RequestLogEvent public APIs. It's useful to poke at them in emitter extensions.

@stale
Copy link

stale bot commented Jun 21, 2019

This issue has been marked as stale due to 280 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the [email protected] list. Thank you for your contributions.

@stale stale bot added the stale label Jun 21, 2019
@stale
Copy link

stale bot commented Jul 5, 2019

This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

@stale stale bot closed this as completed Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants