Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge getUsedSegmentsForInterval and getUsedSegmentAndCreatedDateForInterval into one method #5775

Closed
zhangxinyu1 opened this issue May 14, 2018 · 4 comments
Labels

Comments

@zhangxinyu1
Copy link
Contributor

see #5556

@zhangxinyu1
Copy link
Contributor Author

Hi @gianm,
I want to merge the method getUsedSegmentsForInterval() and getUsedSegmentAndCreatedDateForInterval() of IndexerMetadataStorageCoordinator.java into one method. There is only one difference between them: The former does not include information of created_date, but the latter does. I don't know why created_date is not a part of DataSchema. Could we make DataSchema include created_date?

@stale
Copy link

stale bot commented Jun 21, 2019

This issue has been marked as stale due to 280 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the [email protected] list. Thank you for your contributions.

@stale stale bot added the stale label Jun 21, 2019
@gianm gianm removed stale labels Jul 4, 2019
@stale
Copy link

stale bot commented Apr 9, 2020

This issue has been marked as stale due to 280 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the [email protected] list. Thank you for your contributions.

@stale stale bot added the stale label Apr 9, 2020
@stale
Copy link

stale bot commented May 7, 2020

This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

@stale stale bot closed this as completed May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants