Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CoordinatorRuleManager.rules doesn't need to store ConcurrentHashMap #9292

Closed
leventov opened this issue Jan 30, 2020 · 0 comments · Fixed by #9302
Closed

CoordinatorRuleManager.rules doesn't need to store ConcurrentHashMap #9292

leventov opened this issue Jan 30, 2020 · 0 comments · Fixed by #9302
Labels
Contributions Welcome Improvement Starter

Comments

@leventov
Copy link
Member

CoordinatorRuleManager didn't have a race condition prior to #6898, actually, because the ConcurrentHashMap is never modified after assigning into AtomicReference. So the proper fix was (and the proper action now is) to replace ConcurrentHashMap with simple HashMap.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Contributions Welcome Improvement Starter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Not use ConcurrentHashMap in CoordinatorRuleManager.rules zhenxiao/incubator-druid
1 participant
@leventov