From b3b08722f72f57a3e71b9111930700c1d91e04a2 Mon Sep 17 00:00:00 2001 From: Charles Allen Date: Thu, 19 May 2016 14:55:38 -0700 Subject: [PATCH] Log when a S3 segment move cannot remove old data --- .../main/java/io/druid/storage/s3/S3DataSegmentMover.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/extensions-core/s3-extensions/src/main/java/io/druid/storage/s3/S3DataSegmentMover.java b/extensions-core/s3-extensions/src/main/java/io/druid/storage/s3/S3DataSegmentMover.java index 5d23db3d9501..5e02e9902785 100644 --- a/extensions-core/s3-extensions/src/main/java/io/druid/storage/s3/S3DataSegmentMover.java +++ b/extensions-core/s3-extensions/src/main/java/io/druid/storage/s3/S3DataSegmentMover.java @@ -143,7 +143,13 @@ public Void call() throws Exception if (!config.getDisableAcl()) { target.setAcl(GSAccessControlList.REST_CANNED_BUCKET_OWNER_FULL_CONTROL); } - s3Client.moveObject(s3Bucket, s3Path, targetS3Bucket, target, false); + final Object deletedException = s3Client + .moveObject(s3Bucket, s3Path, targetS3Bucket, target, false) + // See javadoc for moveObject + .get("DeleteException"); + if (deletedException != null) { + log.warn("File at [s3://%s/%s could not be removed: %s", s3Bucket, s3Path, deletedException); + } } } } else {