Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL.params concurrent map read and map write problem #200

Closed
giantpoplar opened this issue Sep 11, 2019 · 2 comments
Closed

URL.params concurrent map read and map write problem #200

giantpoplar opened this issue Sep 11, 2019 · 2 comments

Comments

@giantpoplar
Copy link

What happened:
program crash due to URL.params concurrent map read and map write problem

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

A paramsLock (common/url.go baseUrl struct) is introduced in recent commit to fix concurrent map read and write problem of params. However, this problem has not been completely solved. In function "MergeUrl", params are set without this lock guard.

@hxmhlt
Copy link
Contributor

hxmhlt commented Sep 11, 2019

TKS. I will commit a bug fix pr.

@hxmhlt
Copy link
Contributor

hxmhlt commented Sep 17, 2019

resolved

@hxmhlt hxmhlt closed this as completed Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants