Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dubbo remove demo module] Delete redundant demos #2436

Closed
2 tasks done
zonghaishang opened this issue Sep 4, 2018 · 2 comments
Closed
2 tasks done

[Dubbo remove demo module] Delete redundant demos #2436

zonghaishang opened this issue Sep 4, 2018 · 2 comments

Comments

@zonghaishang
Copy link
Member

  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

  • Dubbo version: 2.7.0-SNAPSHOT
  • Operating System version: mac os
  • Java version: 1.8

Step to reproduce this issue

Pls. provide [GitHub address] to reproduce this issue.

Expected Result

What do you expected from the above steps？

Actual Result

What is actually happen?

If there is an exception, please attach the exception trace:

Just put your stack trace here!
@diecui1202
Copy link

diecui1202 commented Sep 7, 2018 •
edited
Loading

IMO, dubbo-demo is good for users to dive deep into the code, also for us to verify features. So I suggest keep it.

Any Other thoughts?

@zonghaishang
Copy link
Member Author

#2423 will be fix it, close it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@diecui1202 @zonghaishang