Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UT failed on windows with FileNetworkerTest #2838

Closed
2 tasks done
biyuhao opened this issue Nov 27, 2018 · 3 comments
Closed
2 tasks done

UT failed on windows with FileNetworkerTest #2838

biyuhao opened this issue Nov 27, 2018 · 3 comments
Assignees
Labels
help wanted Everything needs help from contributors

Comments

@biyuhao
Copy link
Member

biyuhao commented Nov 27, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

  • Dubbo version: master branch
  • Operating System version: windows 10
  • Java version: 1.8

Steps to reproduce this issue

  1. run FileNetworkerTest on windows platform
  2. UT failed

Pls. provide [GitHub address] to reproduce this issue.

Expected Result

UT passed

What do you expected from the above steps?

Actual Result

What actually happens?
exception thrown
ref File_URI_scheme

If there is an exception, please attach the exception trace:

java.lang.NumberFormatException: For input string: "\Users\XXX\AppData\Local\Temp\junit7860990268511022074\junit2976714168777395029.tmp"

	at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
	at java.lang.Integer.parseInt(Integer.java:580)
	at java.lang.Integer.parseInt(Integer.java:615)
	at org.apache.dubbo.common.URL.valueOf(URL.java:249)
	at org.apache.dubbo.remoting.p2p.support.FileNetworkerTest.testJoin(FileNetworkerTest.java:57)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
	at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
@carryxyh carryxyh added type/enhancement help wanted Everything needs help from contributors labels Nov 27, 2018
@carryxyh carryxyh self-assigned this Nov 27, 2018
@carryxyh
Copy link
Member

Thx for your issue.
This place can indeed be optimized.

@biyuhao
Copy link
Member Author

biyuhao commented Nov 27, 2018

@carryxyh I've sent a PR, would you mind having a look at it? Thanks

@carryxyh
Copy link
Member

I will close this issue via #2848.
Thx for your issue. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Everything needs help from contributors
Projects
None yet
Development

No branches or pull requests

2 participants