Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Reference annotation ignore the @Method annotation #4607

Closed
2 tasks
tswstarplanet opened this issue Jul 19, 2019 · 2 comments
Closed
2 tasks

@Reference annotation ignore the @Method annotation #4607

tswstarplanet opened this issue Jul 19, 2019 · 2 comments
Milestone

Comments

@tswstarplanet
Copy link
Contributor

tswstarplanet commented Jul 19, 2019

  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

  • Dubbo version: 2.7.4-SNAPSHOT
  • Operating System version: MacOS
  • Java version: java11

Steps to reproduce this issue

  1. Config reference like
    @Reference(id = "referenceId1" , methods = {@Method(name = METHOD, timeout = 7000, arguments = @Argument(index = 0))})
    private DemoService demoService;
  1. debug the application, observe if the methods config works

Expected Result

the methods config works

Actual Result

the methods config doesn't work

If there is an exception, please attach the exception trace:

I find that it seems the code following generate the effect

package org.apache.dubbo.config.spring.util;

public class AnnotationUtils {

in the method public static Map<String, Object> getAttributes(Annotation annotation, PropertyResolver propertyResolver, boolean ignoreDefaultValue, String... ignoreAttributeNames)

            if (attributeValue.getClass().isAnnotation()) {
                continue;
            }
            if (attributeValue.getClass().isArray() && attributeValue.getClass().getComponentType().isAnnotation()) {
                continue;
            }

Should we delete these code ?

@Leishunyu
Copy link
Contributor

has remove it #4598

@beiwei30 beiwei30 added this to the 2.7.4 milestone Jul 31, 2019
@beiwei30
Copy link
Member

beiwei30 commented Aug 1, 2019

fixed

@beiwei30 beiwei30 closed this as completed Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants