-
Notifications
You must be signed in to change notification settings - Fork 19.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(i18n): fix the abbr of "March" for the DE language ("Mar" -> "Mrz") #18387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution! |
plainheart
changed the title
Update langDE.ts ("Mar" -> "Mrz)
fix(i18n): fix the abbr of March for the DE language ("Mar" -> "Mrz)
Mar 15, 2023
plainheart
changed the title
fix(i18n): fix the abbr of March for the DE language ("Mar" -> "Mrz)
fix(i18n): fix the abbr of "March" for the DE language ("Mar" -> "Mrz)
Mar 15, 2023
plainheart
previously approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing it out!
The current mothAbbr does not follow ISO8601, which is "Mrz" instead of "Mar" in germany. Please see also datejs implementation: https://github.com/datejs/Datejs/blob/master/build/date-de-DE.js#L9 Another option would be to use "März" instead of "Mrz" - but "Mar" ist not correct.
plainheart
approved these changes
Mar 15, 2023
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
plainheart
changed the title
fix(i18n): fix the abbr of "March" for the DE language ("Mar" -> "Mrz)
fix(i18n): fix the abbr of "March" for the DE language ("Mar" -> "Mrz")
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current mothAbbr does not follow ISO8601, which is "Mrz" instead of "Mar" in germany.
Please see also datejs implementation: https://github.com/datejs/Datejs/blob/master/build/date-de-DE.js#L9
Another option would be to use "März" instead of "Mrz" - but "Mar" ist not correct.
Brief Information
This pull request is in the type of:
What does this PR do?
Change short form for march in german translation to follow ISO 8601
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information