From eb3f0bb2844197b059e55200ab3a490fa5f7bce0 Mon Sep 17 00:00:00 2001 From: chenlei677 Date: Wed, 22 Mar 2023 18:54:33 +0800 Subject: [PATCH 1/2] Supplement startup mode exception information --- .../cdc/connectors/mysql/table/MySqlTableSourceFactory.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/flink-connector-mysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/table/MySqlTableSourceFactory.java b/flink-connector-mysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/table/MySqlTableSourceFactory.java index 1f6acd3ca89..4733d18041b 100644 --- a/flink-connector-mysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/table/MySqlTableSourceFactory.java +++ b/flink-connector-mysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/table/MySqlTableSourceFactory.java @@ -237,10 +237,13 @@ private static StartupOptions getStartupOptions(ReadableConfig config) { default: throw new ValidationException( String.format( - "Invalid value for option '%s'. Supported values are [%s, %s], but was: %s", + "Invalid value for option '%s'. Supported values are [%s, %s, %s, %s, %s], but was: %s", SCAN_STARTUP_MODE.key(), SCAN_STARTUP_MODE_VALUE_INITIAL, SCAN_STARTUP_MODE_VALUE_LATEST, + SCAN_STARTUP_MODE_VALUE_EARLIEST, + SCAN_STARTUP_MODE_VALUE_SPECIFIC_OFFSET, + SCAN_STARTUP_MODE_VALUE_TIMESTAMP, modeString)); } } From d4fcae5795be1b4b1e08f6734ee27b31c3280a59 Mon Sep 17 00:00:00 2001 From: chenlei677 Date: Thu, 23 Mar 2023 11:02:33 +0800 Subject: [PATCH 2/2] fix mysql cdc test bug. --- .../cdc/connectors/mysql/table/MySqlTableSourceFactoryTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/flink-connector-mysql-cdc/src/test/java/com/ververica/cdc/connectors/mysql/table/MySqlTableSourceFactoryTest.java b/flink-connector-mysql-cdc/src/test/java/com/ververica/cdc/connectors/mysql/table/MySqlTableSourceFactoryTest.java index a4f87b905e2..532ab4c6b77 100644 --- a/flink-connector-mysql-cdc/src/test/java/com/ververica/cdc/connectors/mysql/table/MySqlTableSourceFactoryTest.java +++ b/flink-connector-mysql-cdc/src/test/java/com/ververica/cdc/connectors/mysql/table/MySqlTableSourceFactoryTest.java @@ -707,7 +707,7 @@ public void testValidation() { } catch (Throwable t) { String msg = "Invalid value for option 'scan.startup.mode'. Supported values are " - + "[initial, latest-offset], " + + "[initial, latest-offset, earliest-offset, specific-offset, timestamp], " + "but was: abc"; assertTrue(ExceptionUtils.findThrowableWithMessage(t, msg).isPresent()); }