Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][BugFix] Fix the arrow acero not found error when building with arrow 12.0.0 or greater #164

Merged
merged 3 commits into from
May 18, 2023

Conversation

acezen
Copy link
Contributor

@acezen acezen commented May 18, 2023

Signed-off-by: acezen [email protected]

Committed-by: acezen from Dev container

Proposed changes

Since arrow 12.0.0 has move ExecPlan from compute to acero, and new a libarrow_acero.a. This change make libgar to link arrow acero static library when building with arrow 12.0.0 or greater.

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Fixed #163

…r later

Signed-off-by: acezen <[email protected]>

Committed-by: acezen from Dev container
@acezen acezen requested a review from lixueclaire May 18, 2023 06:59
@github-actions
Copy link

github-actions bot commented May 18, 2023

🎊 PR Preview 6c13a97 has been successfully built and deployed to https://alibaba-graphar-build-pr-164.surge.sh

🤖 By surge-preview

acezen added 2 commits May 18, 2023 07:01
Signed-off-by: acezen <[email protected]>

Committed-by: acezen from Dev container
Signed-off-by: acezen <[email protected]>

Committed-by: acezen from Dev container
@acezen acezen merged commit a17b42d into apache:main May 18, 2023
@acezen acezen deleted the 162-fix-link-error-arrow-12 branch May 18, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]:tests target got link error when building with arrow 12.0.0 or greater
2 participants