From 2cbcf1d2d57463ea48b1e6d59dca4f4ae3328d4c Mon Sep 17 00:00:00 2001 From: pancx Date: Sun, 15 Dec 2024 15:18:56 +0800 Subject: [PATCH 1/2] [#5825] improvement(CLI): Update the error message for creating a metalake when the required parameter is missing. Currently, when a metalake is created without specifying the metalake argument, the message "Cannot parse a null or empty identifier" is displayed. This message is unclear and lacks helpful guidance for the user. Update the message to: "! metalake is not defined" to make it more user-friendly and informative. fix some change --- .../java/org/apache/gravitino/cli/GravitinoCommandLine.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java b/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java index 843593487bd..fd26894bcd1 100644 --- a/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java +++ b/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java @@ -28,9 +28,11 @@ import java.nio.charset.StandardCharsets; import java.util.Arrays; import java.util.Map; +import java.util.Objects; import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.HelpFormatter; import org.apache.commons.cli.Options; +import org.apache.gravitino.MetadataObject; import org.apache.gravitino.cli.commands.Command; /* Gravitino Command line */ @@ -174,6 +176,10 @@ private void handleMetalakeCommand() { } else if (CommandActions.LIST.equals(command)) { newListMetalakes(url, ignore, outputFormat).handle(); } else if (CommandActions.CREATE.equals(command)) { + if (Objects.isNull(metalake)) { + System.err.println("! " + MetadataObject.Type.METALAKE.name() + " is not defined"); + return; + } String comment = line.getOptionValue(GravitinoOptions.COMMENT); newCreateMetalake(url, ignore, metalake, comment).handle(); } else if (CommandActions.DELETE.equals(command)) { From 98b39046e0a8e63daa6c70451c9433c330382846 Mon Sep 17 00:00:00 2001 From: pancx Date: Mon, 16 Dec 2024 09:19:17 +0800 Subject: [PATCH 2/2] [#5825] improvement(CLI): Update the entity name Use CommandEntities replace MetadataObject.Type --- .../java/org/apache/gravitino/cli/GravitinoCommandLine.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java b/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java index fd26894bcd1..1e376b8be49 100644 --- a/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java +++ b/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java @@ -32,7 +32,6 @@ import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.HelpFormatter; import org.apache.commons.cli.Options; -import org.apache.gravitino.MetadataObject; import org.apache.gravitino.cli.commands.Command; /* Gravitino Command line */ @@ -177,7 +176,7 @@ private void handleMetalakeCommand() { newListMetalakes(url, ignore, outputFormat).handle(); } else if (CommandActions.CREATE.equals(command)) { if (Objects.isNull(metalake)) { - System.err.println("! " + MetadataObject.Type.METALAKE.name() + " is not defined"); + System.err.println("! " + CommandEntities.METALAKE + " is not defined"); return; } String comment = line.getOptionValue(GravitinoOptions.COMMENT);