Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] <Fix some unit tests that failed to run> #2955

Open
11 tasks
tomsun28 opened this issue Jan 6, 2025 · 9 comments
Open
11 tasks

[Task] <Fix some unit tests that failed to run> #2955

tomsun28 opened this issue Jan 6, 2025 · 9 comments
Assignees
@NikhilMurugesan @yunfan24
Labels
discussion good first issue Good for newcomers

Comments

@tomsun28
Copy link
Contributor

tomsun28 commented Jan 6, 2025

Description

hi, here are some unit tests that failed to run. They are disabled by @Disabled by default. Welcome to claim to fix and enable them.

Task List

  • hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/controller/AlertGroupConvergeControllerTest.java
  • hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/service/AlertDefineExcelImExportServiceTest.java
  • hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/controller/AlertDefineControllerTest.java
  • hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/controller/AlertDefinesControllerTest.java
  • hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/controller/AlertGroupConvergesControllerTest.java
  • hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/notice/impl/DbAlertStoreHandlerImplTest.java
  • hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/reduce/AlarmSilenceReduceTest.java
  • hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/service/AlertDefineYamlImExportServiceTest.java
  • hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/service/AlertGroupConvergeServiceTest.java
  • hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/service/AlertServiceTest.java
  • hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/service/NoticeConfigServiceTest.java
@tomsun28 tomsun28 added good first issue Good for newcomers discussion labels Jan 6, 2025
@NikhilMurugesan
Copy link

CAN I WORK ON THIS
?

@yunfan24
Copy link
Contributor

yunfan24 commented Jan 6, 2025

I can complete some fixes.

@tomsun28
Copy link
Contributor Author

tomsun28 commented Jan 7, 2025

@NikhilMurugesan @yunfan24
welcome, please comment below on the sub-tasks you have claimed.
eg:
hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/controller/AlertGroupConvergeControllerTest.java
hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/service/AlertDefineExcelImExportServiceTest.java

@NikhilMurugesan
Copy link

HI @yunfan24 , As you are an contributor to this repo
hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/controller/AlertGroupConvergeControllerTest.java
hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/service/AlertDefineExcelImExportServiceTest.java
hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/controller/AlertDefineControllerTest.java
hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/controller/AlertDefinesControllerTest.java
hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/controller/AlertGroupConvergesControllerTest.java
hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/notice/impl/DbAlertStoreHandlerImplTest.java
hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/reduce/AlarmSilenceReduceTest.java

Feel free to take these .

As I am new to this repo and new to contributing I will take these 4

hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/service/AlertDefineYamlImExportServiceTest.java
hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/service/AlertGroupConvergeServiceTest.java
hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/service/AlertServiceTest.java
hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/service/NoticeConfigServiceTest.java

@tomsun28 Is this good?

@yunfan24
Copy link
Contributor

yunfan24 commented Jan 7, 2025

@NikhilMurugesan Your approach is good, but I have a concern. The NoticeConfigServiceTest.java has already been modified in this PR. Further modifications might cause merge conflicts. Should we put changes to NoticeConfigServiceTest.java on hold for now?

@NikhilMurugesan
Copy link

Tht is also correct, lets wait for that PR to be merged

@NikhilMurugesan
Copy link

@yunfan24 I have an local issue , could you help me resolve that

@yunfan24
Copy link
Contributor

yunfan24 commented Jan 7, 2025

@yunfan24 I have an local issue , could you help me resolve that我有一个本地问题，你能帮我解决吗

Sure, please describe your issue.

@MasamiYui
Copy link

I can try to solve the following,plz assign it to me
hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/controller/AlertGroupConvergeControllerTest.java
hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/service/AlertDefineExcelImExportServiceTest.java
hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/controller/AlertDefineControllerTest.java
hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/controller/AlertDefinesControllerTest.java
hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/controller/AlertGroupConvergesControllerTest.java
hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/notice/impl/DbAlertStoreHandlerImplTest.java
hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/reduce/AlarmSilenceReduceTest.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikhilMurugesan NikhilMurugesan

@yunfan24 yunfan24

Labels
discussion good first issue Good for newcomers
Projects
Apache HertzBeat (Incubating)
Status: To do
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MasamiYui @tomsun28 @NikhilMurugesan @yunfan24