Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support IN and NOT IN operator in partition filter #175

Open
kazdy opened this issue Oct 17, 2024 · 9 comments · May be fixed by #183
Open

Support IN and NOT IN operator in partition filter #175

kazdy opened this issue Oct 17, 2024 · 9 comments · May be fixed by #183
Assignees
@kazdy @jonathanc-n
Labels
feature p1
Milestone
release-0.3.0

Comments

@kazdy
Copy link
Contributor

kazdy commented Oct 17, 2024 •
edited by xushiyan
Loading

Description of the improvement

I'd like to use IN and NOT IN operators when for partition filter.

SQL equivalent is:

SELECT * FROM huditable WHERE part IN ('2022-01-02', '2022-01-03');
SELECT * FROM huditable WHERE part NOT IN ('2022-01-02', '2022-01-03');

Expected behavior

IN and NOT IN are honored by the PartitionPruner and PartitionFilter.

Additional context

Blocked on #160
@kazdy
Copy link
Contributor Author

kazdy commented Oct 17, 2024

I'll contribute this one

@kazdy kazdy linked a pull request Oct 22, 2024 that will close this issue
Draft
4 tasks
@jonathanc-n
Copy link
Contributor

@kazdy Hullo, are you still working on this? I can help build upon it, but if my recent PR gets merged there will be a lot of conflicts so we could possibly open another pr after. This is a good step towards getting all the predicate functionality

@kazdy
Copy link
Contributor Author

kazdy commented Nov 29, 2024

Hey, I parked it for some time. I'll get back to it next month I hope, feel free to make your changes and I'll resolve conflicts

@xushiyan xushiyan added this to the release-0.3.0 milestone Nov 30, 2024
@xushiyan xushiyan added the p1 label Nov 30, 2024
@xushiyan
Copy link
Member

Sounds good. We'll merge #203 first

@xushiyan
Copy link
Member

xushiyan commented Dec 8, 2024

hey @kazdy #160 is closed now. Do you want to resume this, and any ETA? thanks.

@kazdy
Copy link
Contributor Author

kazdy commented Dec 12, 2024

@xushiyan I want to resume this, I just don't know when I'll have time, so no ETA sorry

@xushiyan
Copy link
Member

@xushiyan I want to resume this, I just don't know when I'll have time, so no ETA sorry

Understood, @kazdy , no worries. We will evaluate the priority in a week, and decide picking it up for 0.3.0 or pushing to a future release.

@jonathanc-n
Copy link
Contributor

@kazdy if you do not have the time, I can probably help take it over. Currently on break this week, can pick it up next week if thats fine with you?

@kazdy
Copy link
Contributor Author

kazdy commented Dec 17, 2024

@jonathanc-n feel free to implement it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazdy kazdy

@jonathanc-n jonathanc-n

Labels
feature p1
Projects
hudi-rs roadmap
Status: Todo
Milestone
release-0.3.0
Development

Successfully merging a pull request may close this issue.

feat: support for in, not in partition filters kazdy/hudi-rs
3 participants
@xushiyan @kazdy @jonathanc-n