Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] for upsert, add uniqueness check when identifier_field_ids is set #1667

Open
kevinjqliu opened this issue Feb 16, 2025 · 2 comments

Comments

@kevinjqliu
Copy link
Contributor

Feature Request / Improvement

More context in #1665

@Fokko
Copy link
Contributor

Fokko commented Feb 16, 2025

I think this should be the other way around. If you use join_cols, and you have a identifier_field_ids set, you want to make sure that the uniqueness constraint still holds.

Typing this, I'm not sure how valuable this is, this would mean that you upsert on a table by ignoring the identifier-fields (or read primary key).

@Fokko
Copy link
Contributor

Fokko commented Feb 16, 2025

Thinking of it, I believe Trino fails when it finds duplicate fields on the read-path, maybe that's a better check to set. That would also cover #1666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants