Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

field-id in avro schema is missing #131

Closed
Tracked by #348
, #543
...
ZENOTME opened this issue Dec 21, 2023 · 9 comments
Closed
Tracked by #348
, #543
...

field-id in avro schema is missing #131

ZENOTME opened this issue Dec 21, 2023 · 9 comments
Labels
bug Something isn't working
Milestone
0.3.0 Release

Comments

@ZENOTME
Copy link
Contributor

ZENOTME commented Dec 21, 2023

According risingwavelabs/risingwave#14106, avro-rs don't serialize the field-id. We will close this issue after the fix be accept by upstream and release it.
@liurenjie1024
Copy link
Contributor

It would be better to link apache avro rust issue here so that we can track it.

@ZENOTME
Copy link
Contributor Author

ZENOTME commented Dec 23, 2023

Track in https://issues.apache.org/jira/browse/AVRO-3920

@Fokko Fokko changed the title field-id in avro schema is miss now field-id in avro schema is missing May 6, 2024
This was referenced May 6, 2024
Closed
Closed
@sdd
Copy link
Contributor

sdd commented Jun 10, 2024

This appears to have been resolved: https://issues.apache.org/jira/browse/AVRO-3920

@sdd
Copy link
Contributor

sdd commented Jun 10, 2024

Thanks, @ZENOTME :-) apache/avro#2650

@ZENOTME ZENOTME closed this as completed Jun 13, 2024
@liurenjie1024
Copy link
Contributor

Thanks @ZENOTME for this pr: apache/avro#2650 But I think we should still make this open since it has not been released yet? I think it will be included in 0.16.1 or 0.17?

@liurenjie1024 liurenjie1024 reopened this Jun 15, 2024
@ZENOTME
Copy link
Contributor Author

ZENOTME commented Jun 15, 2024

Thanks @ZENOTME for this pr: apache/avro#2650 But I think we should still make this open since it has not been released yet? I think it will be included in 0.16.1 or 0.17?

Sorry, I forget that. I find that the last release of Avro-rust was 9 months ago, maybe we can ask them whether there is the plan to release 0.16.1 or 0.17 recently.

@ZENOTME
Copy link
Contributor Author

ZENOTME commented Jun 19, 2024

New info for Avro 0.17: https://issues.apache.org/jira/browse/AVRO-4001. It will be coming soon!

@ZENOTME ZENOTME mentioned this issue Jun 19, 2024
Merged
@liurenjie1024 liurenjie1024 added the bug Something isn't working label Jun 19, 2024
@liurenjie1024 liurenjie1024 added this to the 0.3.0 Release milestone Jun 19, 2024
@Xuanwo
Copy link
Member

Xuanwo commented Aug 14, 2024

This one can be closed?

@Xuanwo Xuanwo mentioned this issue Aug 14, 2024
Closed
15 tasks
@ZENOTME
Copy link
Contributor Author

ZENOTME commented Aug 14, 2024

This one can be closed?

I think we can close it now.

@Xuanwo Xuanwo closed this as completed Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
iceberg-rust
Status: Done
Milestone
0.3.0 Release
Development

No branches or pull requests
4 participants
@sdd @liurenjie1024 @Xuanwo @ZENOTME