-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OAuth Support for iceberg rest client. #238
Comments
I’ll take a look on the issue |
The python implementation is generated by their spec, do we really need to implement the rest client manually? |
I'm ready to give it a try using some OpenAPI rust generators to create a client. If anyone has tried this before and encountered any issues, feel free to share them with me. |
Hi, are you looking at iceberg-python or generated Python module in iceberg repo? Codes in iceberg repo are only used for testing what's the model looks like and not used in production. The actual implementation could be found in link I mentioned above. |
We already have a rest client in catalog/rest directory, you can take a look at it. |
The rest catalog openapi spec could be found here: https://github.com/apache/iceberg/blob/a582968975dd30ff4917fbbe999f1be903efac02/open-api
Python rest catalog client implementation could be found here:
https://github.com/apache/iceberg-python/blob/b026c5d4b7ba5244f67733870c06c952923e6852/pyiceberg/catalog/rest.py
The text was updated successfully, but these errors were encountered: