Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor file_io_s3_test.rs to reuse container for test. #453

Closed
liurenjie1024 opened this issue Jul 10, 2024 · 2 comments · Fixed by #455
Closed

Refactor file_io_s3_test.rs to reuse container for test. #453

liurenjie1024 opened this issue Jul 10, 2024 · 2 comments · Fixed by #455
Labels
good first issue Good for newcomers

Comments

@liurenjie1024
Copy link
Contributor

In #428 we did a refactoring to reuse containers for tests, which improves our tests speed on macos. But file_io_s3_test.rs is still missing, and we should continue the work.
@liurenjie1024 liurenjie1024 added the good first issue Good for newcomers label Jul 10, 2024
@fqaiser94
Copy link
Contributor

I'll take a crack at this

@fqaiser94 fqaiser94 mentioned this issue Jul 12, 2024
Merged
@liurenjie1024
Copy link
Contributor Author

I'll take a crack at this

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
iceberg-rust
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor file_io_s3_test.rs fqaiser94/iceberg-rust
2 participants
@liurenjie1024 @fqaiser94