Upgrade to gradle 8.8

[jbonofre]

Feature Request / Improvement

Upgrade gradle wrapper to 8.3 version.

Query engine

None

[Jake-00]

pr tells us that to update gradle version would omit build failure of breaking changes, we should estimate following impacts.

[ajantha-bhat]

@Jake-00:
I saw your PR of #8577

Yes. We might have to raise issue to RevAPI to track this. We can't really hold the gradle upgrade because of revAPI for so long time.

@nastra: WDYT?

[nastra]

We might have to raise issue to RevAPI to track this

It was not an issue with RevAPI itself, but rather with Gradle. Something in the execution changed that would cause RevAPI failures to not be detected properly.
Is this still an issue with Gradle 8.3?

[jbonofre]

@nastra let me check for the RevAPI failures not detected. Thanks.

[jbonofre]

FYI, I tested revapi with Gradle 8.3 (on my PR). Here's the test I did:

• I added void test(); method in SessionCatalog
• I added the corresponding public void test() {} in RESTSessionCatalog
  So there's actually a change on the API.
  With Gradle 8.1, revapi fails with API/ABI breaks detected..
  With Gradle 8.3, revapi doesn't fail, it doesn't detect the API change.

I'm investigating.

[ajantha-bhat]

With Gradle 8.3, revapi doesn't fail, it doesn't detect the API change.

Yes. Thats what we have observed with Gradle 8.2 also.
Maybe we need to raise an issue to revAPI team. If it is a Gradle issue they will divert us to there.

[jbonofre]

I think the problem is more on gradle or a mix with gradle and revapi gradle plugin.

I'm doing a bisect on gradle to identify the change causing the issue.

[jbonofre]

As gradle 8.4 is now available, I'm updating the PR (I'm also re-testing revapi but I'm pretty sure it will be the same as in Gradle 8.4 :) ).

[jbonofre]

I'm resuming my work on this issue, upgrading to Gradle 8.5 and dealing with revapi.

[Fokko]

@jbonofre Gentle ping on this one.

A later version of Gradle is required to unblock #10209. The 1.14.0 version of Parquet ships with a newer version of Jackson, with JDK21-specific files. These files cause issues with the older version of the Shadow plugin that we're using. The shadow plugin requires a later version of Gradle.

[jbonofre]

Back on it. Sorry for the delay.

[Fokko]

@jbonofre No problem, we're all busy. I've split out the RevAPI change in #10368

[jbonofre]

Yeah. I saw that. Thanks. I'm working on both right now.