-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run revapi workflow on workflow/build system changes #10485
Run revapi workflow on workflow/build system changes #10485
Conversation
Not sure it makes sense to trigger revapi (api compatibility workflow) when gradle or github folders are updated. Can you please provide the rationale here ? The problem with Gradle 8.2+ update is not when revapi is triggered, it's an issue on the revapi gradle plugin itself (see palantir/gradle-revapi#612). I'm working to fix this issue in the plugins (both revapi and shadow) and I have a fallback PR with a So I don't think it makes sense to change the workflow trigger. |
thank you @jbonofre for your review and feedback!
what if i change the revapi (api compatibility workflow) itself? without any change, the build won't trigger, so we won't know if the changed workflow works what if i change something in the build system (e.g. gradle version) that breaks revapi? without any change, the build won't trigger, so we won't know if the build system change impacted the revapi workflow. (of course, this change doesn't safeguard against silent problems like described here #10368 (comment)) |
I understand your point but not sure it would happen. Revapi just checks the Java modules. I'm not against your change, I just wonder if it actually fix/improve something 😃 |
It doesn't fix anything, because nothing is currently broken. The change is supposed to make it less likely that things break in the future. |
ebb300a
to
c58c6d7
Compare
thanks for the merge! |
a PR updating gradle (#10474) should not have green CI because of the revapi problem outlined here #10476 (comment). run the revapi checks when CI workflows or build system configuration changes