-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka Logger. #1312
Merged
Merged
Kafka Logger. #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
membphis
reviewed
Mar 21, 2020
membphis
reviewed
Mar 23, 2020
membphis
reviewed
Mar 23, 2020
membphis
reviewed
Mar 23, 2020
membphis
reviewed
Mar 23, 2020
@Akayeshmantha please rebase your branch with |
Akayeshmantha
force-pushed
the
patch12
branch
3 times, most recently
from
March 23, 2020 11:27
8cb7b1c
to
0b5ee35
Compare
@membphis done |
membphis
previously approved these changes
Mar 24, 2020
@Akayeshmantha It missing doc now. The source code is fine. |
Added @membphis. And rebased with the master 😃 |
membphis
approved these changes
Mar 24, 2020
moonming
approved these changes
Mar 25, 2020
@Akayeshmantha many thx |
SaberMaster
pushed a commit
to SaberMaster/incubator-apisix
that referenced
this pull request
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding kafka plugin.
Issues resolved
Fix #1259