Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove getAttributeMap of ServiceMetada #3542

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Conversation

Jeff-Lv
Copy link
Contributor

@Jeff-Lv Jeff-Lv commented Feb 22, 2019

What is the purpose of the change

remove getAttributeMap of ServiceMetada

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #3542 into 3.x-dev will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             3.x-dev    #3542      +/-   ##
=============================================
- Coverage      63.81%   63.74%   -0.08%     
  Complexity        75       75              
=============================================
  Files            655      655              
  Lines          28422    28422              
  Branches        4808     4808              
=============================================
- Hits           18137    18117      -20     
- Misses          8008     8023      +15     
- Partials        2277     2282       +5
Impacted Files Coverage Δ Complexity Δ
...va/org/apache/dubbo/rpc/model/ServiceMetadata.java 58.33% <0%> (ø) 0 <0> (ø) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-10.87%) 0% <0%> (ø)
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-10.53%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 56.47% <0%> (-5.89%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 71.14% <0%> (-2.02%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 47.91% <0%> (-1.05%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 81.2% <0%> (-0.76%) 0% <0%> (ø)
...bbo/registry/support/ProviderConsumerRegTable.java 85.36% <0%> (+4.87%) 0% <0%> (ø) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0%> (+7.54%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4755a0...3432541. Read the comment docs.

@Jeff-Lv Jeff-Lv merged commit adf4700 into apache:3.x-dev Feb 22, 2019
@Jeff-Lv Jeff-Lv deleted the 3.x-dev branch February 22, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants