Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow addressListner to return new addressList for filtering #3572

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

Jeff-Lv
Copy link
Contributor

@Jeff-Lv Jeff-Lv commented Feb 27, 2019

What is the purpose of the change

allow addressListner to return new addressList for filtering

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #3572 into 3.x-dev will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             3.x-dev    #3572      +/-   ##
=============================================
+ Coverage      63.76%   63.77%   +0.01%     
  Complexity        75       75              
=============================================
  Files            655      655              
  Lines          28436    28437       +1     
  Branches        4811     4812       +1     
=============================================
+ Hits           18132    18137       +5     
+ Misses          8026     8018       -8     
- Partials        2278     2282       +4
Impacted Files Coverage Δ Complexity Δ
.../dubbo/registry/integration/RegistryDirectory.java 79.09% <0%> (-0.26%) 0 <0> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 75% <0%> (-11.12%) 0% <0%> (ø)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 73.58% <0%> (-7.55%) 0% <0%> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 80.48% <0%> (-4.88%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-4.35%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 0% <0%> (ø)
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 68.13% <0%> (-2.2%) 0% <0%> (ø)
.../exchange/support/header/HeaderExchangeServer.java 59.82% <0%> (-0.86%) 0% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 59.27% <0%> (+0.72%) 0% <0%> (ø) ⬇️
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 66.1% <0%> (+0.84%) 0% <0%> (ø) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e76a377...f9bf180. Read the comment docs.

@Jeff-Lv Jeff-Lv merged commit 52c549e into apache:3.x-dev Feb 27, 2019
@Jeff-Lv Jeff-Lv deleted the 3.x-dev branch February 27, 2019 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants