-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dubbo-3886] Integrate with SOFARegistry. #3886
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3886 +/- ##
===========================================
+ Coverage 63.85% 63.95% +0.1%
Complexity 98 98
===========================================
Files 715 718 +3
Lines 31457 31613 +156
Branches 5049 5090 +41
===========================================
+ Hits 20086 20218 +132
- Misses 9061 9078 +17
- Partials 2310 2317 +7
Continue to review full report at Codecov.
|
@ralf0131 Please review this PR. |
I will try to do it today or tomorrow.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please following the guide to add a new module: apache/dubbo-website#350
There are some things to do:
- Add your dependency to dubbo-bom/pom.xml
- Add your dependency to dubbo-distribution/pom.xml
- Update dubbo-dependencies if necessary
- Could you list the license of your dependencies to make sure they are compatible with Apache
...-registry/dubbo-registry-sofa/src/main/java/org/apache/dubbo/registry/sofa/SofaRegistry.java
Outdated
Show resolved
Hide resolved
.../dubbo-registry-sofa/src/main/java/org/apache/dubbo/registry/sofa/SofaRegistryConstants.java
Outdated
Show resolved
Hide resolved
...istry/dubbo-registry-sofa/src/test/java/org/apache/dubbo/registry/sofa/SofaRegistryTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use junit5
b5a6d77
to
b5f8218
Compare
0b1ac21
to
3e6157c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@lovepoem What is you opinion on this? |
I checked the license of dubbo-registry-sofa dependencies. All looks good. |
lgtm |
What is the purpose of the change
#3874
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.