-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
complete lookup method of consul registry and add integration test #3906
Conversation
@beiwei30 Hi Ian, could you help me review this pr? I do some fix in it, I also add a test to increase the code coverage, to ensure everything is fine. |
Codecov Report
@@ Coverage Diff @@
## master #3906 +/- ##
============================================
+ Coverage 63.66% 63.94% +0.28%
- Complexity 71 97 +26
============================================
Files 712 713 +1
Lines 31450 31467 +17
Branches 5073 5073
============================================
+ Hits 20023 20122 +99
+ Misses 9134 9036 -98
- Partials 2293 2309 +16
Continue to review full report at Codecov.
|
...try/dubbo-registry-consul/src/main/java/org/apache/dubbo/registry/consul/ConsulRegistry.java
Show resolved
Hide resolved
Sorry for the late response. I am on it. |
...try/dubbo-registry-consul/src/main/java/org/apache/dubbo/registry/consul/ConsulRegistry.java
Show resolved
Hide resolved
...try/dubbo-registry-consul/src/main/java/org/apache/dubbo/registry/consul/ConsulRegistry.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls. check my comments.
What is the purpose of the change
complete lookup method of consul registry and add integration test. see #3890
Brief changelog
XXXXX
make lookup method return our immediate provider list, just like what we do in https://github.com/apache/incubator-dubbo/blob/9ce0676908adbb5d073727c47b5a32dda153230e/dubbo-registry/dubbo-registry-zookeeper/src/main/java/org/apache/dubbo/registry/zookeeper/ZookeeperRegistry.java#L195 .
Also check this in ConsulRegistryTest.testLookup()
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.