-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Results are mismatch with vanilla Spark when get_json_object({"dScore":0.0215434648799772}, "$.dScore") #4928
Comments
The following unit test case can reproduce the issue. I'm sure that got wrong value while parsing double in function EXPECT_EQ(
"0.0215434648799772",
getJsonObject(R"({"dScore":0.0215434648799772})", "$.dScore"));
---------------------------------------------------------------
[zk] dv:0.0215435 numberResult:0.0215435
Expected equality of these values:
"0.0215434648799772"
Which is: 0x53d043d
getJsonObject(R"({"dScore":0.0215434648799772})", "$.dScore")
Which is: ("0.0215435") Hi @PHILO-HE , reviewing the commit history, I believe you have more expertise in this section. Would you be willing to assist in resolving this issue, please? |
Thanks for reporting this issue! I will take a look. |
Hi @kecookier, it looks the below small patch can fix this issue. Please help verify it. Thanks! |
@PHILO-HE Thanks for your help, I'll try it out later. |
Hi @PHILO-HE , I have tested it, and that patch can fix the bug.
|
Backend
VL (Velox)
Bug description
The following SQL might lead to wrong results, but it's not yet certain if there are other factors involved.
I will try to reproduce later.
Spark version
None
Spark configurations
No response
System information
No response
Relevant logs
The text was updated successfully, but these errors were encountered: