Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-8802][VL] Add specific jdk version for CentOS 8 docker image #8814

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevinw66
Copy link
Contributor

What changes were proposed in this pull request?

Follows #8803

@github-actions github-actions bot added the INFRA label Feb 24, 2025
Copy link

#8802

@PHILO-HE PHILO-HE self-requested a review February 24, 2025 14:34
@PHILO-HE
Copy link
Contributor

There is no such docker image tag. If no jdk specified in the tag name, it means jdk 8 is used. Please check from https://hub.docker.com/r/apache/gluten/tags.

@PHILO-HE
Copy link
Contributor

There is no such docker image tag. If no jdk specified in the tag name, it means jdk 8 is used. Please check from https://hub.docker.com/r/apache/gluten/tags.

Just note it will be created in another pr.

@FelixYBW
Copy link
Contributor

@kevinw66
Copy link
Contributor Author

@PHILO-HE @FelixYBW Hi,due to prefix matching issue, centos-8 will be renamed to centos-8-jdk8 in PR #8803 .

@PHILO-HE
Copy link
Contributor

@PHILO-HE is below set correct?

centos-8-jdk17.  ----- dynamic

centos-8-jdk11.  ----- dynamic

centos-8          ---- dynamic

vcpkg-centos-7   -------static

@FelixYBW, not exactly.

It's true for the below two images.
centos-8 ---- dynamic
vcpkg-centos-7 -------static

But for centos-8-jdk17, it's just used for building Java/Scala code and running some Spark tests with jdk-17. And in this case, we reuse Gluten native libs generated by static build on vcpkg-centos-7.

For centos-8-jdk11, it is not used in CI by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants