Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Add support for some Parquet write options to 3.4 / 3.5 to align with 3.2 / 3.3 #8816

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Feb 24, 2025

This adds support for the following write options to 3.4 / 3.5 Parquet write:

  • block size
    • sql conf: spark.gluten.sql.columnar.parquet.write.blockSize
    • option: parquet.block.size
  • block rows
    • sql conf: spark.gluten.sql.native.parquet.write.blockRows
    • option: parquet.block.rows

The options were supported in 3.2 / 3.3. The patch adds them to 3.4 / 3.5 to make sure the document applies for all Spark versions.

With some other minor code cleanups.

@github-actions github-actions bot added the VELOX label Feb 24, 2025
@apache apache deleted a comment from github-actions bot Feb 24, 2025
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zhztheplayer zhztheplayer marked this pull request as ready for review February 25, 2025 02:53
@zhztheplayer
Copy link
Member Author

@JkSelf thanks

Copy link
Contributor

@JkSelf JkSelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@JkSelf
Copy link
Contributor

JkSelf commented Feb 25, 2025

We can consider updating the documentation to include the configurations for enabling SESSION_LOCAL_TIMEZONE and PARQUET_GZIP_WINDOW_SIZE here.

@zhztheplayer zhztheplayer changed the title [VL] Add support for some Parquet write options to 3.4 / 3.5 as well as in 3.2 / 3.3 [VL] Add support for some Parquet write options to 3.4 / 3.5 to align with 3.2 / 3.3 Feb 25, 2025
@zhztheplayer zhztheplayer merged commit 97c74c2 into apache:main Feb 25, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants