Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Minor cleanups #8824

Merged
merged 1 commit into from
Feb 25, 2025
Merged

[VL] Minor cleanups #8824

merged 1 commit into from
Feb 25, 2025

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Feb 25, 2025

  1. Avoid ... reduceLeft ... error when components are not loaded (although we don't have chance to face this error anymore, add more protections in code)
  2. Rename gluten-core/src/main/scala/org/apache/gluten/execution/GlutenPlan.scala to ValidationResult.scala

@github-actions github-actions bot added the CORE works for Gluten Core label Feb 25, 2025
Copy link

Run Gluten Clickhouse CI on x86

@apache apache deleted a comment from github-actions bot Feb 25, 2025
@marin-ma marin-ma merged commit d6d07a2 into apache:main Feb 25, 2025
52 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_02_25_2025_time.csv log/native_master_02_24_2025_0257b53881_time.csv difference percentage
q1 12.22 11.08 -1.144 90.64%
q2 12.95 11.91 -1.041 91.97%
q3 2.67 3.04 0.364 113.62%
q4 51.44 51.72 0.284 100.55%
q5 9.56 9.28 -0.277 97.10%
q6 4.75 5.27 0.523 111.00%
q7 4.57 4.71 0.135 102.96%
q8 5.00 5.34 0.337 106.73%
q9 16.74 13.90 -2.842 83.03%
q10 12.09 12.71 0.613 105.07%
q11 30.92 27.73 -3.195 89.67%
q12 2.64 2.96 0.325 112.31%
q13 5.90 6.51 0.615 110.43%
q14a 45.31 42.66 -2.654 94.14%
q14b 39.42 39.59 0.172 100.44%
q15 2.34 2.39 0.044 101.88%
q16 6.19 5.06 -1.128 81.78%
q17 5.02 6.47 1.449 128.85%
q18 7.72 8.07 0.357 104.62%
q19 3.04 3.17 0.128 104.21%
q20 2.05 1.85 -0.202 90.14%
q21 0.85 0.80 -0.048 94.30%
q22 4.41 3.62 -0.782 82.25%
q23a 62.04 61.43 -0.613 99.01%
q23b 72.82 73.88 1.061 101.46%
q24a 72.01 73.69 1.686 102.34%
q24b 64.36 69.03 4.662 107.24%
q25 5.24 6.02 0.774 114.77%
q26 2.93 2.27 -0.657 77.55%
q27 2.39 2.59 0.201 108.41%
q28 16.98 18.35 1.372 108.08%
q29 8.56 8.47 -0.090 98.95%
q30 5.19 5.24 0.054 101.03%
q31 8.11 7.50 -0.610 92.48%
q32 1.84 1.95 0.114 106.20%
q33 3.27 3.95 0.678 120.72%
q34 3.20 3.22 0.019 100.60%
q35 7.83 6.84 -0.987 87.40%
q36 2.68 2.32 -0.364 86.44%
q37 3.05 3.27 0.220 107.20%
q38 11.46 11.77 0.307 102.68%
q39a 3.99 4.32 0.330 108.26%
q39b 3.47 3.86 0.388 111.16%
q40 3.41 5.38 1.968 157.68%
q41 1.01 0.61 -0.396 60.76%
q42 0.90 0.95 0.049 105.45%
q43 2.10 2.27 0.170 108.10%
q44 6.02 6.50 0.477 107.92%
q45 3.36 3.30 -0.057 98.29%
q46 3.96 4.14 0.174 104.39%
q47 11.48 9.56 -1.916 83.31%
q48 3.57 3.34 -0.229 93.59%
q49 5.36 6.37 1.013 118.91%
q50 16.90 17.18 0.278 101.65%
q51 7.56 8.53 0.969 112.81%
q52 0.90 1.01 0.111 112.40%
q53 1.58 2.02 0.442 127.95%
q54 5.96 5.55 -0.407 93.17%
q55 0.62 1.58 0.959 255.10%
q56 3.88 4.04 0.159 104.09%
q57 6.60 6.31 -0.293 95.56%
q58 2.32 2.72 0.398 117.17%
q59 4.48 5.18 0.698 115.57%
q60 4.72 4.29 -0.437 90.75%
q61 4.25 4.06 -0.194 95.43%
q62 4.82 2.95 -1.875 61.13%
q63 1.34 1.50 0.159 111.89%
q64 37.31 37.23 -0.087 99.77%
q65 11.95 12.07 0.120 101.01%
q66 2.89 3.40 0.514 117.81%
q67 57.39 58.42 1.025 101.79%
q68 3.47 2.84 -0.629 81.90%
q69 4.84 5.42 0.575 111.88%
q70 5.71 5.51 -0.198 96.53%
q71 5.30 5.23 -0.071 98.65%
q72 21.63 20.59 -1.048 95.16%
q73 2.43 2.12 -0.306 87.41%
q74 17.79 17.66 -0.122 99.32%
q75 23.58 22.91 -0.670 97.16%
q76 7.18 6.72 -0.456 93.65%
q77 2.69 2.78 0.086 103.18%
q78 33.57 33.57 0.001 100.00%
q79 3.97 4.22 0.243 106.12%
q80 12.04 10.61 -1.438 88.06%
q81 6.62 6.57 -0.051 99.23%
q82 5.53 5.62 0.090 101.62%
q83 1.66 1.71 0.054 103.26%
q84 2.79 2.74 -0.045 98.40%
q85 6.68 5.38 -1.305 80.48%
q86 2.19 2.16 -0.031 98.60%
q87 12.32 13.42 1.103 108.95%
q88 15.42 15.56 0.134 100.87%
q89 2.85 2.15 -0.706 75.29%
q90 2.27 1.77 -0.494 78.21%
q91 5.05 4.26 -0.797 84.23%
q92 1.73 1.72 -0.011 99.36%
q93 23.55 23.84 0.297 101.26%
q94 8.51 9.01 0.499 105.86%
q9 56.50 59.63 3.136 105.55%
q5 2.35 2.18 -0.169 92.80%
q96 11.10 10.69 -0.414 96.27%
q97 4.12 2.69 -1.422 65.46%
q98 5.26 5.46 0.198 103.76%
q99 0.55 0.32 -0.230 58.41%
total 1187.15 1187.33 0.176 100.01%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_02_25_2025_time.csv log/native_master_02_24_2025_0257b53881_time.csv difference percentage
q1 24.81 24.90 0.084 100.34%
q2 26.05 26.81 0.765 102.94%
q3 32.97 33.19 0.223 100.68%
q4 27.75 27.98 0.228 100.82%
q5 59.60 61.54 1.947 103.27%
q6 7.02 9.62 2.594 136.95%
q7 38.72 40.23 1.505 103.89%
q8 65.35 65.71 0.362 100.55%
q9 101.55 97.75 -3.796 96.26%
q10 43.39 44.59 1.199 102.76%
q11 17.06 17.27 0.215 101.26%
q12 17.99 16.95 -1.032 94.26%
q13 25.43 25.39 -0.045 99.82%
q14 13.84 13.88 0.037 100.27%
q15 26.60 25.61 -0.985 96.30%
q16 13.26 13.76 0.495 103.74%
q17 77.41 75.40 -2.013 97.40%
q18 114.70 114.88 0.180 100.16%
q19 16.26 12.29 -3.970 75.58%
q20 24.76 24.69 -0.064 99.74%
q21 174.99 172.49 -2.500 98.57%
q22 13.88 10.30 -3.582 74.20%
total 963.39 955.24 -8.151 99.15%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE works for Gluten Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants