Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update the document of velox backend support functions #8835

Closed
wants to merge 1 commit into from

Conversation

xinghuayu007
Copy link
Contributor

What changes were proposed in this pull request?

Update the document 'docs/velox-backend-support-progress.md' and clarify the supported functions.

(Fixes: #ISSUE-ID)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions github-actions bot added the DOCS label Feb 26, 2025
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@marin-ma
Copy link
Contributor

Thanks for working on this. However, we already have an issue #8821 to track the function support. #8822 is for this issue and the function support lists are automatically generated from an internal script. With this approach, we can regularly update the function support list without much manual maintenance in the future.

I will close this one and it's welcomed to review #8822 and the follow-up PRs. Thanks!

@marin-ma marin-ma closed this Feb 26, 2025
@@ -299,20 +299,19 @@ Gluten supports 199 functions. (Drag to right to see all data types)
| array_remove | array_remove | | S | | | | | | | | | | | | | | | | | | | |
| array_repeat | | | S | | S | S | S | S | S | S | S | S | S | S | S | | | | | | | |
| array_sort | array_sort | array_sort | S | | | | | | | | | | | | | | | | | | | |
| array_union | | | | | | | | | | | | | | | | | | | | | | |
| arrays_overlap | array_overlap | S | | | | | | | | | | | | | | | | | | | | |
| array_union | array_union | array_union | S | | | | | | | | | | | | | | | | | | | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are fallback logs

12:35:13.302 WARN org.apache.spark.sql.execution.GlutenFallbackReporter: Validation failed for plan: Project[QueryId=133], due to: 
 - Native validation failed: 
   |- Validation failed due to exception caught at file:SubstraitToVeloxPlanValidator.cc line:1368 function:validate, thrown from file:ExprCompiler.cpp line:475 function:compileRewrittenExpression, reason:Scalar function name not registered: array_union, called with arguments: (ARRAY<DOUBLE>, ARRAY<DOUBLE>).

Seems like array_union is not supported.

| arrays_zip | zip | | S | | | | | | | | | | | | | | | | | | | |
| cardinality | cardinality | | | | | | | | | | | | | | | | | | | | | |
| element_at | element_at | element_at | S | | | | | | | | | | | | | | | | S | S | | |
| exists | any_match | | S | | | | | | | | | | | | | | | | | | | |
| explode, explode_outer | | | | | | | | | | | | | | | | | | | | | | |
| explode_outer, explode | | | | | | | | | | | | | | | | | | | | | | |
| explode, explode_outer | explode | explode | S | | | | | | | | | | | | | | | | | | | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explode is supported, while explode_outer is not. This PR is working on it.

| make_interval | | | | | | | | | | | | | | | | | | | | | | |
| make_timestamp | | | | | | | | | | | | | | | | | | | | | | |
| make_ym_interval | | | | | | | | | | | | | | | | | | | | | | |
| make_interval | make_interval | make_interval | S | | | | | | | | | | | | | | | | | | | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type for "make_interval" is CalendarIntervalType, which is not supported yet.

@@ -442,14 +441,14 @@ Gluten supports 199 functions. (Drag to right to see all data types)
| rank | rank | | S | | | | | | | | | | | | | | | | | | | |
| row_number | row_number | | S | | | | S | S | S | | | | | | | | | | | | | |
| from_csv | | | | | | | | | | | | | | | | | | | | | | |
| from_json | | | | | | | | | | | | | | | | | | | | | | |
| from_json | from_json | from_json | S | | | | | | | | | | | | | | | | | | | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12:38:33.093 WARN org.apache.spark.sql.execution.GlutenFallbackReporter: Validation failed for plan: Project[QueryId=3888], due to: 
 - Native validation failed: 
   |- Validation failed at file:SubstraitToVeloxPlanValidator.cc, line:236, function:validateScalarFunction, reason:Function is not supported: from_json

| schema_of_csv | | | | | | | | | | | | | | | | | | | | | | |
| schema_of_json | | | | | | | | | | | | | | | | | | | | | | |
| to_csv | | | | | | | | | | | | | | | | | | | | | | |
| to_json | | | | | | | | | | | | | | | | | | | | | | |
| to_json | to_json | to_json | S | | | | | | | | | | | | | | | | | | | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12:37:58.806 WARN org.apache.spark.sql.execution.GlutenFallbackReporter: Validation failed for plan: Project[QueryId=3176], due to: 
 - Native validation failed: 
   |- Validation failed due to exception caught at file:SubstraitToVeloxPlanValidator.cc line:1368 function:validate, thrown from file:ExprCompiler.cpp line:475 function:compileRewrittenExpression, reason:Scalar function name not registered: to_json, called with arguments: (ROW<a:INTEGER,b:INTEGER>).

@@ -388,7 +387,7 @@ Gluten supports 199 functions. (Drag to right to see all data types)
| aggregate | | aggregate | S | | | | | | | | | | | | | | | | | | | |
| any | | | | | | | | | | | | | | | | | | | | | | |
| approx_count_distinct | approx_distinct | | S | | S | S | S | S | S | S | S | S | | S | | | | | | | | |
| approx_percentile | | | | | | | | | | | | | | | | | | | | | | |
| approx_percentile | approx_percentile | approx_percentile | S | | | | | | | | | | | | | | | | | | | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12:35:31.555 WARN org.apache.spark.sql.execution.GlutenFallbackReporter: Validation failed for plan: ObjectHashAggregate[QueryId=675], due to: 
 - Native validation failed: 
   |- Validation failed at file:SubstraitToVeloxPlanValidator.cc, line:1235, function:validate, reason:approx_percentile was not supported in AggregateRel.

@@ -371,13 +370,13 @@ Gluten supports 199 functions. (Drag to right to see all data types)
| timestamp | | | | | | | | | | | | | | | | | | | | | | |
| timestamp_micros | | timestamp_micros | S | | | | | | | | | | | | | | | | | | | |
| timestamp_millis | | timestamp_millis | S | | | | | | | | | | | | | | | | | | | |
| timestamp_seconds | | | | | | | | | | | | | | | | | | | | | | |
| timestamp_seconds | timestamp_seconds | timestamp_seconds | S | | | | | | | | | | | | | | | | | | | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12:35:41.114 WARN org.apache.spark.sql.execution.GlutenFallbackReporter: Validation failed for plan: Project[QueryId=985], due to: 
 - Native validation failed: 
   |- Validation failed due to exception caught at file:SubstraitToVeloxPlanValidator.cc line:1368 function:validate, thrown from file:ExprCompiler.cpp line:475 function:compileRewrittenExpression, reason:Scalar function name not registered: timestamp_seconds, called with arguments: (INTEGER).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants