Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat][C++] Redesign and unify the implementation of validation in C++ Writer/Builder #183

Closed
lixueclaire opened this issue Jun 5, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@lixueclaire
Copy link
Contributor

lixueclaire commented Jun 5, 2023

Is your feature request related to a problem? Please describe.
We need to develop a more comprehensive and consistent approach to validation across all of GraphAr's tools and libraries. As the first step, to redesign and unify the implementation of validation for Writer and Builder in the C++ library.

Describe the solution you'd like

  • define the validation level in utils
  • clarify the concepts of weak validate-level and strong validate-level
  • hide the Validate interface to users and use validate-level as a parameter of the writing operation
  • unify the implementation in Writer and Builder

Additional context
Next steps is to extend the validation level to other tools and libraries of other languages.

@lixueclaire lixueclaire added the enhancement New feature or request label Jun 5, 2023
@lixueclaire lixueclaire self-assigned this Jun 5, 2023
@lixueclaire lixueclaire changed the title [Feat] Redesign and unify the implementation of validation in C++ Writer/Builder [Feat][C++] Redesign and unify the implementation of validation in C++ Writer/Builder Jun 5, 2023
@lixueclaire
Copy link
Contributor Author

solved by #186

@acezen acezen added this to the Release v0.7.0 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants