From 2309ed3729a3bd19c8dd60c6bce02988c224be80 Mon Sep 17 00:00:00 2001 From: acezen Date: Mon, 24 Apr 2023 17:24:41 +0800 Subject: [PATCH 1/3] Make the curl interface private --- cpp/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt index 0f6381aff..866a0d394 100644 --- a/cpp/CMakeLists.txt +++ b/cpp/CMakeLists.txt @@ -204,7 +204,7 @@ macro(build_gar) target_link_libraries(gar PRIVATE OpenSSL::SSL) endif() if (CURL_FOUND) - target_link_libraries(gar PUBLIC CURL::libcurl) + target_link_libraries(gar PRIVATE CURL::libcurl) endif() if (APPLE) target_link_libraries(gar "-framework CoreFoundation") From f82915d8bab5fc28803420659fb9cd657f6f3c9f Mon Sep 17 00:00:00 2001 From: acezen Date: Mon, 24 Apr 2023 17:53:14 +0800 Subject: [PATCH 2/3] Fix --- cpp/CMakeLists.txt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt index 866a0d394..99df54cab 100644 --- a/cpp/CMakeLists.txt +++ b/cpp/CMakeLists.txt @@ -244,6 +244,9 @@ if (BUILD_EXAMPLES) if(OPENSSL_FOUND) target_link_libraries(${E_NAME} PRIVATE OpenSSL::SSL) endif() + if (CURL_FOUND) + target_link_libraries(gar PRIVATE CURL::libcurl) + endif() endforeach() endif() @@ -314,6 +317,9 @@ if (BUILD_TESTS) if(OPENSSL_FOUND) target_link_libraries(${target} PRIVATE OpenSSL::SSL) endif() + if (CURL_FOUND) + target_link_libraries(gar PRIVATE CURL::libcurl) + endif() endmacro() add_test(test_info SRCS test/test_info.cc) From 87e7c66e260151a9d69a8fe9c3d48681d91004f3 Mon Sep 17 00:00:00 2001 From: acezen Date: Mon, 24 Apr 2023 18:00:06 +0800 Subject: [PATCH 3/3] Fix --- cpp/CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt index 99df54cab..76394df0e 100644 --- a/cpp/CMakeLists.txt +++ b/cpp/CMakeLists.txt @@ -245,7 +245,7 @@ if (BUILD_EXAMPLES) target_link_libraries(${E_NAME} PRIVATE OpenSSL::SSL) endif() if (CURL_FOUND) - target_link_libraries(gar PRIVATE CURL::libcurl) + target_link_libraries(${E_NAME} PRIVATE CURL::libcurl) endif() endforeach() endif() @@ -318,7 +318,7 @@ if (BUILD_TESTS) target_link_libraries(${target} PRIVATE OpenSSL::SSL) endif() if (CURL_FOUND) - target_link_libraries(gar PRIVATE CURL::libcurl) + target_link_libraries(${target} PRIVATE CURL::libcurl) endif() endmacro()