[kie-issues#1723] Allow dot character in metadata attributes #2828
Conversation
This reverts commit 6644d2b.
jomarko
changed the title
There was a problem hiding this comment.
Thank you for the changes @Abhitocode . Just one question from me inline.
| @@ -36,6 +36,7 @@ | |||
| public class StringUtils { | |||
|
|
|||
| public static final String ALPHA_NUM_REGEXP = "^[a-zA-Z0-9\\-\\_]*$"; | |||
| public static final String ALPHA_NUM_UNDERSCORE_DOT_REGEXP = "^[a-zA-Z0-9\\-\\_\\.]*$"; | |||
There was a problem hiding this comment.
Maybe we should reflect also \\- in the constant name?
There was a problem hiding this comment.
Thank you for the suggestion @jomarko , yes it makes sense. I'll update that.
|
@Abhitocode thank you for pushed updates. Please let us know once the PR is done and ready for a review. Then we should convert it from a draft PR to regular PR to run all CI checks. |
|
@Abhitocode is this ready to be reviewed, please? |
|
Hi @yesamer @jomarko, apologies for the delay in reply as I was travelling and away from system. PR is ready but to note when I tried to test the same I had issues with building the editor, I have followed the steps, while |
There was a problem hiding this comment.
I can confirm I was able to use dot in metadata name
Steps I used to build and run editor:
- start
devbox shell export NODE_OPTIONS=--max_old_space_size=4096pnpm bootstrap -F @kie-tools/online-editor...pnpm -F @kie-tools/online-editor... build:devpnpm -F @kie-tools/online-editor start
|
@Abhitocode Thank you, no worries. Please contact me in private to tackle together the issues you're facing in your local |
|
@jomarko Thank you for the confirmation and the steps : ) |
As a result of the work in apache/incubator-kie-kogito-runtimes#3740, the jbpm.enable.multi.con flag needs to be defines as process metadata attribute. However, the process designer does not allow the dot (.) character in the name of metadata attributes.
In order for users to define this process metadata attribute in the designer, it needs to be renamed in using only allowed characters.
Closes: apache/incubator-kie-issues#1723