Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Draft 1 - Wrap runs within OpenTracing spans #2403

Closed
wants to merge 1 commit into from

Conversation

jpkrohling
Copy link

This is just a first draft, intended to start a discussion on the OpenTracing integration. This includes also a concrete OpenTracing tracer implementation (Jaeger) but the code itself is only using OpenTracing APIs.

Things to discuss:

  • How to use other Trace implementations. I'm not sure how the classpath works for Scala applications, but from the OpenTracing's perspective, it will get whatever implementation is on the classpath (ideally, there would be exactly one)
  • Location of the span -- I added the OpenTracing code on the run() method on the invoker, but I'm not 100% familiar with OpenWhisk yet. Is this the right place?

This is how it looks like in Jaeger with this PR:

List of traces (only one span per trace for now):
image

Span details:
image

If this PR is merged, I'll work on context propagation, so that a trace would have more spans (example: if hello invokes aloha, both are shown in the same trace)

@jpkrohling jpkrohling force-pushed the JPK-WrapRunsWithinSpans branch from 8ed4372 to 156998c Compare June 21, 2017 05:25
@jpkrohling
Copy link
Author

Closed in favor of #2413

@jpkrohling jpkrohling closed this Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant