[wip] Draft 1 - Wrap runs within OpenTracing spans #2403
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a first draft, intended to start a discussion on the OpenTracing integration. This includes also a concrete OpenTracing tracer implementation (Jaeger) but the code itself is only using OpenTracing APIs.
Things to discuss:
run()
method on the invoker, but I'm not 100% familiar with OpenWhisk yet. Is this the right place?This is how it looks like in Jaeger with this PR:
List of traces (only one span per trace for now):
![image](https://user-images.githubusercontent.com/13387/27344658-65997290-55e7-11e7-8fc2-a23f67e9d4af.png)
Span details:
![image](https://user-images.githubusercontent.com/13387/27344693-7ba2319e-55e7-11e7-8904-845b912b9714.png)
If this PR is merged, I'll work on context propagation, so that a trace would have more spans (example: if
hello
invokesaloha
, both are shown in the same trace)